ci: fix deploy artifact and cache restore warnings - #5409
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
🟡 Changes recommended
The workflow can fail on runs where .git-committers-cache.json is missing because the committer-cache artifact upload now errors instead of gracefully handling absence.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the GitHub Pages deploy workflow to eliminate deprecation/warning noise and ensure the committer-cache artifact is actually transferred between jobs.
Changes:
- Remove the unused mkdocs-material
.cacherestore steps that were producing restore warnings. - Bump artifact upload/download actions to newer major versions.
- Ensure
.git-committers-cache.jsonis uploaded as an artifact (including hidden files) so the package job can consume it.
File summaries
| File | Description |
|---|---|
.github/workflows/deploy.yml |
Removes unused mkdocs cache restore and updates artifact upload/download configuration for deploy packaging. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/upload-artifactto v7 andactions/download-artifactto v8 so they run on Node.js 24 instead of the deprecated Node 20 runtime..git-committers-cache.jsonwithinclude-hidden-files: true. The file is written by the committer hook, but upload-artifact skips dotfiles by default, so the cache never reached the package job..cacherestore. This site does not generate that directory, so restore hit a stale prefix key, warnedFailed to restore:, and then skipped save.Test plan
deploy.ymlrun should have no Node 20, hidden-file, or cache-restore annotationscommitter-cache-zh/committer-cache-enartifacts should be presentMade with Cursor